update to JuliaInterpreter@0.8 #24
Conversation
| @@ -65,8 +64,7 @@ function exec_notification(conn, state::DebuggerState, params::ExecArguments) | |||
|
|
|||
| ex = Meta.parse(params.code) | |||
|
|
|||
| state.top_level_expressions, _ = JuliaInterpreter.split_expressions(Main, ex) | |||
| state.current_top_level_expression = 0 | |||
| state.expr_splitter = JuliaInterpreter.ExprSplitter(Main, ex) # TODO: line numbers ? | |||
There was a problem hiding this comment.
If you don't want the line number, the actual statement should always be ex.args[2].
There was a problem hiding this comment.
I thought that we may need to fix line numbers for this code block (params.code) like what we did for Juno. It's actually not related to the update of JuliaInterpreter, and we can improve this later.
Co-authored-by: Tim Holy <tim.holy@gmail.com>
|
let's wait until Revise@3.0 comes out ;) |
|
So we now have the problem that JuliaInterpreter@0.8 is only compatible with Julia 1.5, afaict. Need to look into restoring backwards compat before this can be merged, I think. |
|
It's compatible with Julia 1, Julia 1.5, and nightly. I don't remember how hard it would be to fix. GitHub's lovely |
updates to JuliaInterpreter@0.8, which in turn will be the requirement to update Revise@3.0
ref: JuliaDebug/JuliaInterpreter.jl#425
closes: #23