Skip to content

Conversation

@pfitzseb
Copy link
Member

or an exception occurs.

This completely fixes julia-vscode/julia-vscode#1850 for me.

For every PR, please check the following:

@pfitzseb pfitzseb requested a review from davidanthoff March 16, 2021 19:25
@pfitzseb pfitzseb added the bug Something isn't working label Mar 16, 2021
@pfitzseb pfitzseb added this to the Next Patch milestone Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #48 (a21d5eb) into master (b347fbf) will increase coverage by 1.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   90.50%   91.59%   +1.09%     
==========================================
  Files           4        4              
  Lines         200      226      +26     
==========================================
+ Hits          181      207      +26     
  Misses         19       19              
Flag Coverage Δ
unittests 91.59% <100.00%> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core.jl 86.61% <100.00%> (+1.34%) ⬆️
src/typed.jl 100.00% <0.00%> (ø)
src/interface_def.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b347fbf...a21d5eb. Read the comment docs.

@davidanthoff davidanthoff merged commit 6f5b4c8 into master Mar 16, 2021
@davidanthoff davidanthoff deleted the sp/close-msg-queues branch March 16, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Julia processes not terminated when VS Code is closed

3 participants