Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end completion #84

Merged
merged 2 commits into from
Jun 20, 2017
Merged

Add end completion #84

merged 2 commits into from
Jun 20, 2017

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Jun 13, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #84 into master will decrease coverage by 0.3%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   33.79%   33.48%   -0.31%     
==========================================
  Files          24       24              
  Lines        1086     1096      +10     
==========================================
  Hits          367      367              
- Misses        719      729      +10
Impacted Files Coverage Δ
src/provider_completions.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b583fd5...138bf29. Read the comment docs.

@andyferris
Copy link

Will this decrement indentation of end automatically as I type it?

@ZacLN
Copy link
Contributor Author

ZacLN commented Jun 14, 2017

At the moment in vscode de-indenting occurs on hitting enter (after end, else, etc.)

@andyferris
Copy link

OK, I see that now. This will become more obvious after this fix :)

@davidanthoff
Copy link
Member

@andyferris If you want to add another voice over at the VS Code repo to fix this properly, here is the issue: microsoft/vscode#2272.

@andyferris
Copy link

Done.

@davidanthoff davidanthoff merged commit 57f6f86 into julia-vscode:master Jun 20, 2017
@ZacLN ZacLN deleted the end-compl branch June 23, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants