Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get_symbol_server #190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Oct 10, 2020

Adds a function to get symbols for the given module or current environment

@aminya aminya changed the title feat: get_sybmol_server feat: get_symbol_server Oct 11, 2020
@aminya aminya force-pushed the get-symbol-server branch 6 times, most recently from 8677e11 to 3351d90 Compare October 11, 2020 01:48
@aminya aminya force-pushed the get-symbol-server branch from 3351d90 to 13a6563 Compare October 11, 2020 01:50
@aminya
Copy link
Contributor Author

aminya commented Oct 11, 2020

@davidanthoff @ZacLN I have added the tests for this. Although all the tests pass online, it fails in the CI! Could you check this?

image

@davidanthoff
Copy link
Member

What is the use-case for this? I'm a bit hesitant to add more public facing APIs in general, and in this case I don't understand what this would be used for :)

@aminya
Copy link
Contributor Author

aminya commented Jan 5, 2021

What is the use-case for this? I'm a bit hesitant to add more public facing APIs in general, and in this case I don't understand what this would be used for :)

See julia-vscode/StaticLint.jl#220 (comment)

@davidanthoff davidanthoff added this to the Triage milestone Jan 12, 2021
@davidanthoff davidanthoff added the enhancement New feature or request label Jan 12, 2021
@davidanthoff
Copy link
Member

Do we still need this PR, or is the plan with a new external Lint.jl package superseding this?

@davidanthoff davidanthoff modified the milestones: Triage, Backlog Mar 12, 2021
@davidanthoff davidanthoff removed this from the Backlog milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants