[AUTO] Format files using DocumentFormat #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/make.jl
Outdated
| ) | ||
|
|
||
| deploydocs(; | ||
| repo="github.com/julia-vscode/SymbolServer.jl", | ||
| repo = "github.com/julia-vscode/SymbolServer.jl" |
There was a problem hiding this comment.
This comma should not be removed (it should neither add nor remove commas in this situation).
| @take(max_versions) |> | ||
| collect) | ||
| ) |> | ||
| collect |
There was a problem hiding this comment.
The indentation here seems to fall back to the align defaults, whereas it should just be based on indent levels.
| isfile(x) | ||
| catch | ||
| false | ||
| end |
There was a problem hiding this comment.
These line breaks should not be added.
There was a problem hiding this comment.
try isfile(x); catch; false end
is automatically rewritten across lines atm
There was a problem hiding this comment.
Yeah, I think I probably identified a couple of instances that are all based on the same underlying logic here. We just need an option for that, right?
| let allns = Base.IdSet{Symbol}() | ||
| oneverything((m, s, x, state) -> push!(allns, s)) | ||
| allns | ||
| end |
There was a problem hiding this comment.
These line breaks should not be added.
There was a problem hiding this comment.
just to clarify you mean the line break where there semicolon was?
There was a problem hiding this comment.
Yes, and I guess also the line break after the first = shouldn't be added. I just should stay one line as in the original.
test/runtests.jl
Outdated
| @test occursin(r"^vscjlsymserv-\w{8}-\w{4}$", basename(p)) | ||
| else | ||
| @test occursin(r"^/tmp/vscjlsymserv-\w{8}(?:-\w{4}){3}-\w{12}$", p) | ||
| end |
There was a problem hiding this comment.
Shouldn't add these line breaks.
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
3 times, most recently
from
14cf5ec to
425eea8
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
5ded21a to
bca565f
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
bca565f to
77165c2
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
77165c2 to
b03cb53
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
b03cb53 to
75502f8
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
75502f8 to
697f032
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
697f032 to
04949a3
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
04949a3 to
5f3d394
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
5f3d394 to
264d604
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
264d604 to
321e7e4
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
fc90ea4 to
35c341a
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
3 times, most recently
from
9d6b4de to
26ccc86
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
26ccc86 to
19a5cf5
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
19a5cf5 to
04d3aaf
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
f20057e to
22ae4fa
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
13dff49 to
15f6346
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
15f6346 to
38740ce
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
3 times, most recently
from
0290800 to
783ac90
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
4 times, most recently
from
10d467a to
c86ef1a
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
c86ef1a to
660a78c
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
660a78c to
2b23a5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocumentFormat.jl would suggest these formatting changes