Require is not defined #189
Comments
…require works again.
|
I've commented the fix to enable I think it is safe to enable it but we should consider Electron removed default TRUE to @julian-alarcon let me know if it is ok for you and i will removed the comment to fix |
|
@julian-alarcon can you assign this to me? ( so i can found in my Issue tab :-) ) |
…: true to let "require" workson client side.
* resolved package.json conflict * fix window-controlled require electron to match recent changed in mainstream. * fix package json about-window requirement * #189 Force nodeIntegration and contextIsolation to let require works again. * Undo Force nodeIntegration and contextIsolation to let require works again. * fix package.json doubled lines * #189 forced contextIsolation: false and nodeIntegration: true to let "require" workson client side. * UnreadNumberObserver is now in a separated js file * UnreadNumberObserver is now in a separated js file fix performance cache * UnreadNumberObserver better tassonomy * client js and css are now in a separated file. Using clientInjector to load, cache and inject them. * Multiple unreadMessageObserver handler. * Integrated did-create-window and child-window.js suggested by @joax * Better client injector strategy. Moved all clinet files into /public dir * #122, #173 Added context menu wilth Editing actions. * #122 Context menu will show first 50 chars of the clicked link url * context-menu: undo will appear only on editable element. * try fix clear unreadmessageicon in some cases OWA * unread-observer "custom_2": attempting to be multilanguage * #10 fixed Right click on child windows. * #10 fixed Right click on child windows. * update electron to "^16.0.5" in order to fix annoying bug described here electron/electron#31152 * update electron to "^16.0.9" in order to fix annoying bug described here electron/electron#31152 --------- Co-authored-by: Julian Alarcon <jalarcon@lendingfront.com> Co-authored-by: Julian Alarcon <alarconj@gmail.com>
…"require" workson client side.
|
@MagiusCHE @julian-alarcon Disabling context isolation is actually breaking SSO corporate login for any login page using javascript and this has been going on since version 0.5.0. Context isolation is on by default in all recent electron releases. If something is broken with contextIsolation on, it should be fixed by implementing the migration scenario proposed on electron documentation site. Turning it off is a workaround not a solution. For specific cases, there's an ongoing PR which would let users turn it off by configuration while switching it back on by default => #314 . |
After downloading the deb package and trying to see if this would actually give me desktop notifications I get this error:
The text was updated successfully, but these errors were encountered: