Right click spell check context menu and update of dependencies #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that this build is failing because of static node/electron versioning in the build files. It does build an appimage on fedora33 using latest node-lts and electron. |
|
Closing this PR so i can move my own branches ahead. Let me know if you ever care to sync up on these things. |
julian-alarcon
approved these changes
Dec 11, 2021
There was a problem hiding this comment.
Looks great to me! I just tested and it worked as intended. Thank you @haukened !
I'm going to merge it.
julian-alarcon
pushed a commit
that referenced
this pull request
Nov 2, 2023
* add right click context menu for spelling * prevent popup unless there is an error or suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a right click spell check context menu, with automatic spelling suggestions.
It also updates all dependencies to current version. Tested and build on Fedora 33 using AppImage.
Closes: #15
Addresses: