Test PR 1 #10
Open
Test PR 1 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceptions (space-wizards#1815) * Add test that puts all components on an entity and checks for no exceptions Also fix all the exceptions that happened because of this * Add comments to the test * Fix nullable errors * Fix more nullable errors * More nullable error fixes * Unignore basic actor component * Fix more nullable errors * NULLABLE ERROR * Add string interpolation * Merge if checks * Remove redundant pragma warning disable 649 * Address reviews * Remove null wrappers around TryGetComponent * Merge conflict fixes * APC battery component error fix * Fix power test * Fix atmos mapgrid usages
Entity steering wasn't properly checking if the target was deleted. Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
…ds#1864) Co-authored-by: Víctor Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
…rds#1862) Co-authored-by: Víctor Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
…t together (space-wizards#1860) * Started new Lobby * -Proper styling -Use a scrollcontainer :smilethink: * Too lazy to add a stylerule, too young to optimize css * Fix typo Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
* Add art assets for cloning * Added a 'Scan DNA' button to the medical scanner * Made the UI update unconditional for the medical scanner until checks for power changes are in place * Update Medical scanner to reflect powered status and fix space-wizards#1774 * added a 'scan dna' button the the medical scanner that will add the contained bodies Uid to a list in CloningSystem, fixed an issue with the menu not populating if the scanner starts in an unpowered state * Add disabling logic to 'Scan DNA' button on medical scanner * Removed un-used libraries * Added playing parameter to radiatingLightComponent, changed it's animation key to radiatingLight * refactored RadiatingLight into a visualizer * Added different light animations for differnt power states of a flashlight * split out the radiating light visualizer into two seperate visualizers * further refactored and tweaked handheldlight animations * further lantern light tweaks * removed un-used attributes in flashlight and lantern prototypes * fix null check in handheldlightcomponent
* Add NPC faction tags Some stuff isn't easy to represent by the existence of components so tags are intended to provide that functionality for AI usage. I was 50/50 on having all tags in the 1 component or splitting it into 2. I'm leaning towards 2. This would be for stuff like say "CanMimic" so the mimic knows it's allowed to look like a specific prototype, or something like "smg" on a gun so it can say smg-specific barks for instance (as currently smgs and pistols look the same from a component perspective). This also means combat behaviors aren't hardcoded per faction, plus it makes it easy to update faction relations during events. * Factions command Update faction relationships via commands. * Remove command TODO * Woops Forgot to commit these items * Serializer writing and parsing * linq me up fam Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
* Bolt Action * Shotguns * Revolver + Outline * In Magazines: show bullets as numbers plus the usual bullet stuff * Empty bullets have another texture
UI was being updated every tick even when not necessary. Ideally you'd just update the UI based on events but this is fine for now. Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
* Bolt action ver fixes * Fixes bolt-action playing two sounds when cycling on empty magazine * MagazineBarrel open/close bolt verb visibility * mag stuff * Dirty checks on guns Co-authored-by: py01 <pyronetics01@gmail.com>
…izards#1870) * Add test for adding each component individually to entities * Put one-to-one test before all-at-once test
* Fixed * Dunno what that file was
Need to cover up the lewds. Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
…pace-wizards#1914) * Fix atmospherics statics unreliably failing parallel tests * Cache getting atmosphere system
Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
This system haunts my nightmares and I'm gonna refactor it before release. Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
…izards#1916) * Fix errors when gas mixtures are created on class instantiation * Fix mistake
* First Accent Prototype * -RegisterSystem -Fixed addaccent cmd -Spanish accent * -list is now ? -Checks if the accent is already added -Made components public * owo whats this * special word filter * Eeeeeeeeee * Better? * -Use a delegate func -Made some funcs not static -Moved SentenceRegex * InjectDependencies * Name change? Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
* First Prototype * Command Window * Dropdown * Is this better? * That's kinda better? * Added divider * Shit * Check if Admin Menu & Commands are allowed * -Funcy Shit -Now gets properly the playerlist -Fixed kick reason * Dropdown Improvement with some more func * -Added DirectCommand for commands that don't need a ui -Added RestartRound * Better way to make DirectCommandButtons * -Some new Tabs -Player list * -Split Buttons -Regions -Fixed Test Command * Some server buttons * Playerlist alignment * Fucky SpawnEntites & SpawnTiles in AdminBus * -Debug Buttons -Few more commands * -Make dem controls thicc -SpinBox * Escape Kick Reason * Only create the window when you press the button * Adds StationEvents * Nullable "fixes" * This thing wasn't made for buttons * Call other constructor for empty CommandButton * Request method in the interface * -Pushed most Controls to be fields -No more dict passing -Removed test cmd -Regions to better navigate * -Bound to key -Removed from escape menu -Remember cmd windows -Close all cmd windows on toggle * -Moved dependency * Merge fixes Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
* Add strip verb * Merge some of the verb and candragdrop checks
* loc strings, formatting fixes * Fix indentation Co-authored-by: Víctor Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
* (Re)add healing component * Do range check only when healing someone else
Recyclers only check for intersecting entities that have been triggered via collision instead of actively querying it every tick. This means they pretty much don't show up on the profiler when idle. Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
* ExAct for lockers * ToArray Co-authored-by: py01 <pyronetics01@gmail.com>
Co-authored-by: py01 <pyronetics01@gmail.com>
* -ItemStatus for BatteryGuns -EjectCell Verb -Using the gun throws the battery also on the ground * Copy the flashlight and call it a day * Name a red fruit * Remove SoundGunshot
…roperly (space-wizards#1927) * Merge branch 'master' of https://github.com/space-wizards/space-station-14 into cuff-fix * yml * event bus
…1895) * Add button that displays your SSS role and allies * Capitalize button name * Add cases for 0, 1 and invalid number of allies * Make the ally syncing system saner
* PipeNode * Pipe prototypes * Fixes Default NodeGroup not being registered by NodeGroupFactory * GasNet * PumpComponent * IPipeNet * PipeComponent * misc naming, yaml * PipeComponent rework * PipeNet gas transfer from pipes * PipeNet correctly combines gas on combining with other group * Client ignores piping components * AfterRemake * PipeNet remake simplification * IGasMixtureHolder on PipeComponent, IPipeNet * PipeContainerComponent * BasePump * DebugPump * IgnoredComponent fix * Pipe LocalAir and Air * comments * Pump fix * PipeNet fix * name simplification * PipeDirection name changes * BaseVentComponent and DebugVentComponent * Moves Pipe to own file * DebugVentComponent moved to own file * BaseScrubberComponent * DebugScrubberComponent * IgnoredComponents update * scrubber prototype * vent prototype fix * comments * Removes vent and scrubber PipeDirection check * PipeContainer, Pipe, and PipeNode refactor * Yaml cleanup * pump prototype fix * Removes AssumeAir usage from old IGasMixtureHolders * Simplfies Vent & Scrubber to use AtmosHelper methods * Vents and scrubbers invalidate the coordinate they changed the gas of * UpdatedPipingComponent * ScrubberComponent renamed to SiphonComponent * Removes PumpSystem * Removes framTime from UpdatedPiping * PipeNetDevices * PipeNetDevice updated by GridAtmosphereComponent * PipeNets react from update in GridAtmosphereComponent * GridAtmosphereComponent stores PipeNets/PipeNetDevices to be updated in queue * diff fix * Removes debug gas starting in pipes * type safety in IPipeNet when combining groups * null checks * GridAtmos stores PipeNets and PipeNetDevices in List * comments * rogue curly bracket * ProcessPipeNets update fix * RemovePipeNet fix * PipeNet update() unique index * fix diff * Integration test fixes * Error Logging * error fix Co-authored-by: py01 <pyronetics01@gmail.com>
Add delay to flushing Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
* Implement disposal trunk eject on incomming entities * Move variable declaration into if block Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
* Adds IFireAct, ITemperatureExpose * Use AtmosDirection instead of Direction for Atmos * Refactor atmos to heavily rely on arrays and bitflags. Adds F A S T M O S and reduces atmos tech debt heavily. * Optimize and fix more stuff * Kinda improve superconduction * Pipenet is a word * T U R B O M O S * Address reviews * Small optimization * Superconduct is also a word * Remove check * Cleanup tile atmosphere * Correct a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
Technical details
Media
Breaking changes
Changelog