Correct the initialization of the variable "firstTick" #827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "tick" handler code, there's a flag called
firstTick
that is used to avoid updating a property value that's already correct for the current tween. However,firstTick
is initialized based on the state of thetimeStart
value, which is unset on the first tick; the initialization incorrectly inverts that test, using!!timeStart
instead of!timeStart
.The upshot of this is that the test to avoid updating a property an all but the first tick actually only avoids updating the property on the first tick; for most of the animation that optimization is ignored. Worse, that can cause issues for force-fed property values that might need initialization on that first tick (see issue 543).