Fix crash on empty chapters

julien-c · Oct 22, 2018 · 124d461 · 124d461
1 parent 4fc7b77
commit 124d461
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/epub.js b/epub.js
@@ -558,7 +558,7 @@ class EPub extends EventEmitter {
 
                 var title = '';
                 if (branch[i].navLabel && typeof branch[i].navLabel.text == 'string') {
-                    title = branch[i].navLabel && branch[i].navLabel.text || branch[i].navLabel===branch[i].navLabel ?
+                    title = branch[i].navLabel && branch[i].navLabel.text || branch[i].navLabel===branch[i].navLabel && branch[i].navLabel.text.length > 0  ?
                          (branch[i].navLabel && branch[i].navLabel.text || branch[i].navLabel || "").trim() : '';
                 }
                 var order = Number(branch[i]["@"] && branch[i]["@"].playOrder || 0);

diff --git a/test/test.ts b/test/test.ts
@@ -20,4 +20,11 @@ mocha.describe('EPub', () => {
 			`/images/`
 		);
 	});
+
+	mocha.it('supports empty chapters', () => {
+		var branch = [{navLabel: { text: '' }}];
+		const epub = new EPub();
+		var res = epub.walkNavMap(branch, [], []);
+		assert.ok(res);
+	});
 });