Throw better errors when there are parsing issues #49
Conversation
test/test.ts
Outdated
| @@ -27,4 +33,19 @@ mocha.describe('EPub', () => { | |||
| var res = epub.walkNavMap(branch, [], []); | |||
| assert.ok(res); | |||
| }); | |||
|
|
|||
| mocha.it('raises descriptive errors', () => { | |||
| // const epub = new EPub('./example/alice.epub') | |||
There was a problem hiding this comment.
what's weird is that if this line is uncommented instead of the below, the tests still pass when they shouldn't 🤔 not sure if I'm parsing it wrong or what
There was a problem hiding this comment.
Hmm, mocha doesn't wait for callbacks to be executed, does it?
There was a problem hiding this comment.
We should move to async/await... :)
There was a problem hiding this comment.
ah, you're right. I haven't written mocha tests w/ done for a while.
But you're also right that we should use promises, so I added a tool for awaiting events and now it works like a charm!
test/test.ts
Outdated
| mocha.it('basic parsing', () => { | ||
| const epub = new EPub('./example/alice.epub'); | ||
|
|
||
| epub.on('end', ()=> { | ||
| assert.ok(epub.metadata.title) |
There was a problem hiding this comment.
added some basic coverage
| @@ -19,6 +19,10 @@ | |||
| "type": "git", | |||
| "url": "http://github.com/julien-c/epub.git" | |||
| }, | |||
| "files": [ | |||
| "epub.js", | |||
There was a problem hiding this comment.
these are the only two files actually needed at runtime for the user
|
ok, we should be good here! Added extra tests. My editor also removed trailing whitespace (which makes the div look extra big, but it's not). let me know if that's an issue. :) |
|
lgtm, feel free to merge, thanks for improving this:) |
|
sweet! can you release to npm when you have a chance? |
|
hmm, I think you released last time, no? |
|
(if not the case I can add you as a maintainer on npm, if that works for you) |
|
Oh, so I am. I had forgotten. 😁 I'll take care of that! |
This is both a little more descriptive about where the error is raised, plus actually broadcasts the error contents. I added a test with a broken version of alice in wonderland (there's an invalid
&in a chapter title)While I was in there, I added the
filesproperty so we don't ship tests and theepubfiles in the npm package. Drops the package size pretty dramatically.