Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developed RandEvent and add statement-based logging test #414

Conversation

heehehe
Copy link
Contributor

@heehehe heehehe commented Aug 5, 2023

1. Developed RandEvent

2. Add statement-based logging test : TestStatementConnectionSetting

  • Since RandEvent only works with "statement-based logging",
    we added TestStatementConnectionSetting class in pymysqlreplication/tests/test_basic.py
    and set binlog_format='STATEMENT' only in this class.
  • Any other events with statement-based logging could be tested in this class.

@julien-duponchelle
Copy link
Owner

Awesome. Can you solve the conflicts? I think I introduce conflict with my last merge

@mikaniz
Copy link
Contributor

mikaniz commented Aug 20, 2023

Awesome. Can you solve the conflicts? I think I introduce conflict with my last merge

I solved the conflicts. Thanks!

@julien-duponchelle julien-duponchelle merged commit 986bf5c into julien-duponchelle:main Aug 20, 2023
@julien-duponchelle
Copy link
Owner

Great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants