-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developed RandEvent and add statement-based logging test #414
Merged
julien-duponchelle
merged 24 commits into
julien-duponchelle:main
from
python-mysql-replication-kr:feature/rand-event
Aug 20, 2023
Merged
Developed RandEvent and add statement-based logging test #414
julien-duponchelle
merged 24 commits into
julien-duponchelle:main
from
python-mysql-replication-kr:feature/rand-event
Aug 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-replication/python-mysql-replication into feature/rand-event
Awesome. Can you solve the conflicts? I think I introduce conflict with my last merge |
I solved the conflicts. Thanks! |
Great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Developed
RandEvent
RandEvent
class based on these following documents2. Add statement-based logging test :
TestStatementConnectionSetting
RandEvent
only works with "statement-based logging",we added
TestStatementConnectionSetting
class in pymysqlreplication/tests/test_basic.pyand set
binlog_format='STATEMENT'
only in this class.