Remove duplicated Affected columns output in UpdateRowsEvent #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No good reason, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This Pull Request aims to remove the duplicate "Affected columns" output in the
UpdateRowsEventclass.Description
The
_dump()method in bothRowsEventandUpdateRowsEventclasses includes a print statement for the number of affected columns. The duplicate output appears when usingUpdateRowsEvent.Changes
print("Affected columns: %d" % self.number_of_columns)from the_dump()method in theUpdateRowsEventclass.Is there a specific reason for the duplicate "Affected columns" output? I'd appreciate any feedback on this.