Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add properties in gtid event #586

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add properties in gtid event #586

wants to merge 7 commits into from

Commits on Dec 6, 2023

  1. Add properties in gtid event 

    Motivation:
GtidEvent is aleady implemented but there are missing 6 properties.
If we respect these properties, user can use GtidEvent with more convenient.

Motivation:
- Fix(event.py): Add two properties.
- Add(test_basic.py): Add test for GtidEvent.

Result:
for now on, user can use read_immediate_commit_timestamp and read_original_commit_timestamp properties.
    @Bue-von-hon
    taehun.kim authored and Bue-von-hon committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    14fb3ef View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @Bue-von-hon
    taehun.kim authored and Bue-von-hon committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    87b13fe View commit details
    Browse the repository at this point in the history

  3. Resolves in code review

    @Bue-von-hon
    taehun.kim authored and Bue-von-hon committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0ec673d View commit details
    Browse the repository at this point in the history

  4. Update pymysqlreplication/tests/test_basic.py 

    Co-authored-by: sean.k1 (Umhyunsik) <sean.k1@kakaoent.com>
    @Bue-von-hon @sean-k1
    Bue-von-hon and sean-k1 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    e6b2a54 View commit details
    Browse the repository at this point in the history

  5. Update pymysqlreplication/tests/test_basic.py 

    Co-authored-by: sean.k1 (Umhyunsik) <sean.k1@kakaoent.com>
    @Bue-von-hon @sean-k1
    Bue-von-hon and sean-k1 authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    a35b344 View commit details
    Browse the repository at this point in the history

  6. Resolves in code review

    @Bue-von-hon
    Bue-von-hon committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    76c35d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Fix mysql versionfor test

    @Bue-von-hon
    Bue-von-hon committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3b182d7 View commit details
    Browse the repository at this point in the history