Fix #16 - Improving performance of profiles loading #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, gut search for the path of Xorg to check if a GUI is available If it returns an error, this means no GUI is available. But this error must not be printed. It's only used to find out if a GUI is available
There is a lot of commands that doesn't require to load profiles But because of how "init()" works, gut was loading every profiles and password before running the command. This led to performance issues on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves performance of gut.
Rather than loading all profiles on each launch, gut will load them only if the command requires it.
For example,
statusdoesn't need to load any profiles. Before this pull request, gut would load all profiles even if it's not needed.Changes done
To stop this behaviour, the ˋinit` function in the ˋprofileˋ package has been renamed.
This new function is now called on top of every exported functions of the package so that profiles are loaded when needed.
Note : the function won't run twice thanks to a global boolean variable.
Performance improvement over commands that doesn't require any profiles
This test not scientific at all has been run on Fedora on a DO 512MB ram VPS.