✨ Add flag -v to show version #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To retrieve gut version, now you can run `gut -v` or `gut version` To be able to run `gut -v`, I had to create a controller for the root cmd. By default, if no controller is linked to a command, cobra will show the help. Now, root has a controller : if the -v flag is present, it fetches the version from the telemetry package and prints it. If not, it calls cmd.help() to show the help as before I have also created a version cmd that does the same a `gut -v`. The version is added to the build by goreleaser thanks to ldflags. If gut is built from source, goreleaser is not used so the gut version can't be shown. To remediate this, gut -v falls back to "You are running a built from source version of Gut"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To retrieve gut version, now you can run
gut -vorgut versionTo be able to run
gut -v, I had to create a controller for the root cmd.By default, if no controller is linked to a command, cobra will show the help.
Now, root has a controller : if the -v flag is present, it fetches the version from the telemetry package and prints it.
If not, it calls cmd.help() to show the help as before
I have also created a version cmd that does the same a
gut -v.The version is added to the build by goreleaser thanks to ldflags.
If gut is built from source, goreleaser is not used so the gut version can't be shown.
To remediate this, gut -v falls back to "You are running a built from source version of Gut"