Skip to content

Window shade fix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cseymr wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Window shade fix #3

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
583dc5c
Fixes error when setLevel called by windowShade
Aug 2, 2018
359686a
fixes incorrect logging statement, and improved number check
Aug 18, 2018
bc164b0
This checks the current level before submitting the request - hopeful…
Aug 21, 2018
4fce8bd
Stops ST sending close/open updates when they are not needed
Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion fibaro_fgr_222/fibaro_fgr_222.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,11 @@ def stop() {
def open() {
logger.debug("open")
def currentWindowShade = device.currentValue('windowShade')
if (currentWindowShade == "open") {
logger.debug("already open - nothing to do")
return
}

if (currentWindowShade == "opening" || currentWindowShade == "closing") {
sendEvent(name: "windowShade", value: "partially open")
sendEvent(name: "switch", value: "on")
Expand All @@ -243,6 +248,11 @@ def open() {
def close() {
logger.debug("close")
def currentWindowShade = device.currentValue('windowShade')
if (currentWindowShade == "closed") {
logger.debug("already closed - nothing to do")
return
}

if (currentWindowShade == "opening" || currentWindowShade == "closing") {
sendEvent(name: "windowShade", value: "partially open")
sendEvent(name: "switch", value: "on")
Expand Down Expand Up @@ -292,7 +302,19 @@ def refresh() {
], 500)
}

def setLevel(level) {
def setLevel(requestedLevel) {
if (!requestedLevel.isNumber()) {
log.debug ("Cannot convert ${requestedLevel ?: 'null'} to a number")
return
}
int level = requestedLevel as int

int currentLevel = device.currentValue("level") as int
if (currentLevel == level) { //nothing to do
log.debug ("level is already ${level} - nothing to do :^)")
return;
}

if (invert) {
level = 100 - level
}
Expand Down