✨ Wrap some methods with useCallback (#526)

juliencrn · Mar 5, 2024 · d42741f · d42741f
1 parent 9b65ce8
commit d42741f
Show file tree

Hide file tree

Showing 8 changed files with 33 additions and 11 deletions.
diff --git a/.all-contributorsrc b/.all-contributorsrc
@@ -1691,6 +1691,13 @@
       "avatar_url": "https://avatars.githubusercontent.com/u/3635023?v=4",
       "profile": "https://github.com/misidoro",
       "contributions": ["code"]
+    },
+    {
+      "login": "gromchen",
+      "name": "Yuriy Gromchenko",
+      "avatar_url": "https://avatars.githubusercontent.com/u/828918?v=4",
+      "profile": "https://crowds.space/",
+      "contributions": ["code"]
     }
   ],
   "contributorsPerLine": 7,

diff --git a/.changeset/metal-guests-raise.md b/.changeset/metal-guests-raise.md
@@ -0,0 +1,5 @@
+---
+"usehooks-ts": patch
+---
+
+Wrap `useCountdown` methods with `useCallback` (from #326 by @gromchen)
diff --git a/.changeset/perfect-pianos-hear.md b/.changeset/perfect-pianos-hear.md
@@ -0,0 +1,5 @@
+---
+"usehooks-ts": patch
+---
+
+Wrap `useCounter` methods with `useCallback` (from #326 by @gromchen)
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
@@ -414,6 +414,7 @@ Big thanks go to all our contributors! [[Become a contributor](https://github.co
     <tr>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/kyrylo-soulandwolf"><img src="https://avatars.githubusercontent.com/u/54762253?v=4?s=64" width="64px;" alt="kyrylo-soulandwolf"/><br /><sub><b>kyrylo-soulandwolf</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=kyrylo-soulandwolf" title="Code">💻</a> <a href="https://github.com/juliencrn/usehooks-ts/issues?q=author%3Akyrylo-soulandwolf" title="Bug reports">🐛</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/misidoro"><img src="https://avatars.githubusercontent.com/u/3635023?v=4?s=64" width="64px;" alt="Miguel Isidoro"/><br /><sub><b>Miguel Isidoro</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=misidoro" title="Code">💻</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://crowds.space/"><img src="https://avatars.githubusercontent.com/u/828918?v=4?s=64" width="64px;" alt="Yuriy Gromchenko"/><br /><sub><b>Yuriy Gromchenko</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=gromchen" title="Code">💻</a></td>
     </tr>
   </tbody>
 </table>

diff --git a/README.md b/README.md
@@ -17,7 +17,7 @@
 [![License](https://badgen.net/badge/License/MIT/blue)](https://github.com/juliencrn/usehooks-ts/blob/master/LICENSE)
 ![npm bundle size](https://img.shields.io/bundlephobia/minzip/usehooks-ts)
 ![npm](https://img.shields.io/npm/v/usehooks-ts)<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[![All Contributors](https://img.shields.io/badge/all_contributors-240-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-241-orange.svg?style=flat-square)](#contributors-)
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 
 <br />
@@ -428,6 +428,7 @@ Big thanks go to all our contributors! [[Become a contributor](https://github.co
     <tr>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/kyrylo-soulandwolf"><img src="https://avatars.githubusercontent.com/u/54762253?v=4?s=64" width="64px;" alt="kyrylo-soulandwolf"/><br /><sub><b>kyrylo-soulandwolf</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=kyrylo-soulandwolf" title="Code">💻</a> <a href="https://github.com/juliencrn/usehooks-ts/issues?q=author%3Akyrylo-soulandwolf" title="Bug reports">🐛</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/misidoro"><img src="https://avatars.githubusercontent.com/u/3635023?v=4?s=64" width="64px;" alt="Miguel Isidoro"/><br /><sub><b>Miguel Isidoro</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=misidoro" title="Code">💻</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://crowds.space/"><img src="https://avatars.githubusercontent.com/u/828918?v=4?s=64" width="64px;" alt="Yuriy Gromchenko"/><br /><sub><b>Yuriy Gromchenko</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=gromchen" title="Code">💻</a></td>
     </tr>
   </tbody>
 </table>

diff --git a/packages/usehooks-ts/README.md b/packages/usehooks-ts/README.md
@@ -17,7 +17,7 @@
 [![License](https://badgen.net/badge/License/MIT/blue)](https://github.com/juliencrn/usehooks-ts/blob/master/LICENSE)
 ![npm bundle size](https://img.shields.io/bundlephobia/minzip/usehooks-ts)
 ![npm](https://img.shields.io/npm/v/usehooks-ts)<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[![All Contributors](https://img.shields.io/badge/all_contributors-240-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-241-orange.svg?style=flat-square)](#contributors-)
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 
 <br />
@@ -428,6 +428,7 @@ Big thanks go to all our contributors! [[Become a contributor](https://github.co
     <tr>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/kyrylo-soulandwolf"><img src="https://avatars.githubusercontent.com/u/54762253?v=4?s=64" width="64px;" alt="kyrylo-soulandwolf"/><br /><sub><b>kyrylo-soulandwolf</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=kyrylo-soulandwolf" title="Code">💻</a> <a href="https://github.com/juliencrn/usehooks-ts/issues?q=author%3Akyrylo-soulandwolf" title="Bug reports">🐛</a></td>
       <td align="center" valign="top" width="14.28%"><a href="https://github.com/misidoro"><img src="https://avatars.githubusercontent.com/u/3635023?v=4?s=64" width="64px;" alt="Miguel Isidoro"/><br /><sub><b>Miguel Isidoro</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=misidoro" title="Code">💻</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://crowds.space/"><img src="https://avatars.githubusercontent.com/u/828918?v=4?s=64" width="64px;" alt="Yuriy Gromchenko"/><br /><sub><b>Yuriy Gromchenko</b></sub></a><br /><a href="https://github.com/juliencrn/usehooks-ts/commits?author=gromchen" title="Code">💻</a></td>
     </tr>
   </tbody>
 </table>

diff --git a/packages/usehooks-ts/src/useCountdown/useCountdown.ts b/packages/usehooks-ts/src/useCountdown/useCountdown.ts
@@ -131,10 +131,10 @@ export function useCountdown(
   /**
    * Will set running false and reset the seconds to initial value
    */
-  const resetCountdown = () => {
+  const resetCountdown = useCallback(() => {
     stopCountdown()
     resetCounter()
-  }
+  }, [stopCountdown, resetCounter])
 
   const countdownCallback = useCallback(() => {
     if (count === countStop) {

diff --git a/packages/usehooks-ts/src/useCounter/useCounter.ts b/packages/usehooks-ts/src/useCounter/useCounter.ts
@@ -1,4 +1,4 @@
-import { useState } from 'react'
+import { useCallback, useState } from 'react'
 
 import type { Dispatch, SetStateAction } from 'react'
 
@@ -32,15 +32,17 @@ interface UseCounterOutput {
 export function useCounter(initialValue?: number): UseCounterOutput {
   const [count, setCount] = useState(initialValue ?? 0)
 
-  const increment = () => {
+  const increment = useCallback(() => {
     setCount(x => x + 1)
-  }
-  const decrement = () => {
+  }, [])
+
+  const decrement = useCallback(() => {
     setCount(x => x - 1)
-  }
-  const reset = () => {
+  }, [])
+
+  const reset = useCallback(() => {
     setCount(initialValue ?? 0)
-  }
+  }, [initialValue])
 
   return {
     count,