Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for MediaQuery #194

Closed
wants to merge 1 commit into from
Closed

No support for MediaQuery #194

wants to merge 1 commit into from

Conversation

mod7ex
Copy link

@mod7ex mod7ex commented Aug 20, 2022

added overload for MediaQuery

@mod7ex
No support for MediaQuery
d25de16 
added overload for MediaQuery
juliencrn added a commit that referenced this pull request Sep 30, 2022
@juliencrn
feat: add support for media query (#194)
a26eaf3
@juliencrn juliencrn mentioned this pull request Sep 30, 2022
Merged
1 task
@juliencrn
Copy link
Owner

Hi @modex98,

Thanks for your PR, it's a good idea!
Unfortunately, this repo changed a lot since you've pushed this PR.
I've created another PR (#221) with your code.
Please, could you add a unit test to demonstrate how to use this new support.

@juliencrn juliencrn closed this Sep 30, 2022
juliencrn added a commit that referenced this pull request Oct 13, 2022
@juliencrn
feat: add support for media query (#194)
1ab6164
juliencrn added a commit that referenced this pull request Oct 13, 2022
@juliencrn
feat: add media query support (#194 from @modex98)
1891d6e
juliencrn added a commit that referenced this pull request Oct 13, 2022
@juliencrn
feat: add media query support (#194 from @modex98)
d27880f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mod7ex @juliencrn