Update useScript.ts #197
Closed
Update useScript.ts #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it so we get initial load status on first mount Potentially, we could have a global `Record<string, string|undefined>` defined rather than relying on `querySelector` to make it faster.
KATT
commented
Aug 29, 2022
Comment on lines
-11
to
-13
| if (!src) { | ||
| setStatus('idle') | ||
| return |
There was a problem hiding this comment.
Deleted this, it felt weird to have an implicit '' as an acceptable value, if anything I'd say we should do string | null
juliencrn
added a commit
that referenced
this pull request
Sep 30, 2022
|
Hi @KATT, Thanks for this interesting PR, unfortunately the repository structure have been changed since you've opened your PR. Please, could you review this change? |
juliencrn
added a commit
that referenced
this pull request
Oct 13, 2022
juliencrn
added a commit
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cachedScriptStatuses-record for short-circuting & avoiding DOM-lookupPotentially, we could have a globalRecord<string, string|undefined>defined rather than relying onquerySelectorto make it faster.