Fix useLocalStorage API

[pedrobslisboa]

The way useLocalStorare was built does not reflect useState behavior.

You guys are passing the getter to the setter instead of getting the previous value, which does not reflect the useState API. It can produce a lot of bugs since the useState api works async and need to get the previous value on the setter, instead of directly the getter, to work correctly.

You can check out the problem running it here: https://codesandbox.io/s/uselocalstorage-sample-mistake-uxms2b

You can check out the solution working here: https://codesandbox.io/s/uselocalstorage-sample-working-right-4ls3ox?file=/src/App.tsx

Same issue:
uidotdev/usehooks#156

[pedrobslisboa]

@juliencrn

[henriqemalheiros]

Ran into the same issue. There is an older PR trying to solve it too (#242). Yours is missing the window.dispatchEvent that notifies other useLocalStorages that have the same key.

[valyrie97]

Ill piggy back on here:

• There's two invocations to value(prev) which doesnt comply with useState.
• window being undefined is now defined to silently "fail"
• Could you write a test to demonstrate the problem and the fix? (I'm not sure if its the same as in useLocalStorage complies with useState #242 but there is a test case there if you want to reference)

[juliencrn]

Fixed by #436, thanks all