Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed order in lock() function to adjust padding before changing the overflow #516

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

novacdenis
Copy link
Contributor

Changed the order because when we set the overflow to hidden, the scrollbar disappears; therefore, the scrollbar width is always zero. I couldn't reproduce it in a test because the scrollbar widths are always 0 inside a test.

testing-library/react-testing-library#353

Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: d52143a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@novacdenis novacdenis changed the title Changed order in lock() function to adjust padding before changing the overflow fix: Changed order in lock() function to adjust padding before changing the overflow Feb 29, 2024
@juliencrn
Copy link
Owner

Hi @novacdenis,
As I merged #521 before, this PR now only includes test changes.
Thank you!

@juliencrn juliencrn merged commit 12c1d94 into juliencrn:master Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants