-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: new CPLEX wrapper #261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
===========================================
+ Coverage 53.84% 69.24% +15.39%
===========================================
Files 14 15 +1
Lines 1469 2432 +963
===========================================
+ Hits 791 1684 +893
- Misses 678 748 +70
Continue to review full report at Codecov.
|
I've added MOI callbacks. Note: This is a breaking change for people using the existing generic CPLEX callbacks since there were a few bugs. I've commented some out and changed the inputs to be 0-indexed using However, I don't think this is an issue given that I think we should re-write the existing C -> Julia wrapper with Clang. The next release is going to be massively breaking anyway. |
I'm in favor of merging this as-is, and opening issues to address the remaining TODO's. They're relatively minor compared to the full re-write, and it will be easier to review smaller PR's. We're currently passing 2.5k MOI tests :) |
I'm guessing no one will want to/have time to review this, so I will leave this open another day and then merge. The tests passing CI (thanks IBM!) and the number of closed issues, speak for themselves. |
@odow how many hours did you expend getting this up and running? |
It was only a day and a couple of odd bits and pieces. It's pretty similar to Gurobi. I think Xpress is a different story. Although check the solution caching. I think you need to do something similar? |
CPLEX might be even closer to xpress. I will take a look. |
Nominally passing tests with exclusions/hacks. Remaining TODO items:
pass model name to innerAt a minimum, this PR:
Closes #98
Closes #200
Closes #222
Closes #225
Closes #230
Closes #241
Closes #242
Closes #243
Closes #249
Closes #250