-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite CPLEX using Clang #316
Conversation
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
===========================================
- Coverage 69.80% 54.07% -15.74%
===========================================
Files 16 7 -9
Lines 2520 2702 +182
===========================================
- Hits 1759 1461 -298
- Misses 761 1241 +480
Continue to review full report at Codecov.
|
As the deprecation path, any use of existing functions (or the
|
Proposed discourse post below. I think the post, plus the error message, plus code to revert the changes, plus the fact that the people that will be hit with this are people writing solver-dependent callbacks and so hopefully more knowledgable/already fought with the existing API will mean that the pain should be short-lived.
|
This PR is a little hard to review, so I propose merging into |
Yeah I don't think I'll be able to do a thorough review of this. Perhaps leave open for a couple days before merging in case some of the repo watchers plan to take a look? |
The main things to test/review are the updated callbacks and deprecation strategy. |
Ha. I obviously forgot to update the binary for travis. Nice to know that the MOI wrapper also works for 12.9 though. But I think we should keep the lower-bound of 12.10. I'm traveling the next few days, so I probably won't have time to update the binary before next week. |
In the discourse post:
should be
|
Merging this for now, with the expectation that I will fix a couple of the remaining unresolved issues and give people a few weeks to test before tagging a new release. Thoughts on adjusting the discourse announcement to be "Breaking changes are coming, test on the |
Tests currently fail due to a use-after-free error with the callbacks on my Mac. Still debugging why/where.Same comment as Gurobi: jump-dev/Gurobi.jl#346
Closes #16
Closes #42
Closes #92
Closes #140
Closes #121
Closes #172
Closes #174
Closes #175
Closes #209
Closes #268
Closes #269
Closes #270
Closes #279
Closes #287
Closes #297
Closes #300
Closes #304
Closes #312
Closes #313