Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pass_names to AbstractOptimizerAttribute #395

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

odow
Copy link
Member

@odow odow commented Apr 3, 2022

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #395 (9a378fb) into master (f79a6ed) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   50.57%   50.62%   +0.05%     
==========================================
  Files           7        7              
  Lines        3937     3941       +4     
==========================================
+ Hits         1991     1995       +4     
  Misses       1946     1946              
Impacted Files Coverage Δ
src/MOI/MOI_wrapper.jl 92.01% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79a6ed...9a378fb. Read the comment docs.

model = CPLEX.Optimizer()
@test model.pass_names == false
MOI.set(model, CPLEX.PassNames(), true)
@test model.pass_names == true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test model.pass_names == true
@test model.pass_names

@@ -206,6 +206,14 @@ function test_getlongparam()
return
end

function test_PassNames()
model = CPLEX.Optimizer()
@test model.pass_names == false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test model.pass_names == false
@test !model.pass_names

@odow odow merged commit 548c342 into master Apr 4, 2022
@odow odow deleted the od/PassNames branch April 4, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants