add lib dir to Libdl.DL_LOAD_PATH #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 6, 2018 13:23
|
The MathOptInterface v0.5 deprecation of cantransform, canaddconstraint, canaddvariable, canset, canmodify, and candelete functions has to be resolved next |
larssp
commented
Sep 6, 2018
| @@ -1,7 +1,7 @@ | |||
| julia 0.6 | |||
| BinDeps | |||
| MathProgBase 0.5.5 0.8 | |||
| MathOptInterface 0.4.1 0.5 | |||
| MathOptInterface 0.4.1 0.6 | |||
|
Before you go too far down this path, please put changes for updating from MOI 0.5 to 0.6 in a separate PR to keep things easy to review. Also keep in mind that tests need to pass on both Julia 0.6 and 0.7 before we merge. If you can get them passing on 1.0 as well, that's even better. |
| @@ -2,7 +2,7 @@ module CbcMathProgSolverInterface | |||
|
|
|||
| using Cbc.CbcCInterface | |||
|
|
|||
| importall MathProgBase.SolverInterface | |||
| using MathProgBase.SolverInterface | |||
|
|
|||
There was a problem hiding this comment.
using only replaces parts of what importall was doing, but see #65.
|
this PR is premature, closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves build failure #63