-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-GCC BinaryBuilder Binary Dependencies for Julia v0.7-v1.0 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides binaries with new multi-gcc BinaryProvider that should work with official julia binaries and custom source-builds. In particular, fixes #85, fixes #56, fixes #48, and fixes #30.
To avoid future issues like #56 (and jump-dev/SCS.jl#107 (comment)) the binaries are self contained:
using the separate dynamic libraries for dependencies would not provide an advantage until there is Pkg3 support for binary dependencies (right now each COIN solver would download its own copy of each dependency, which could cause unexpected symbol clashes if the solvers are independently updated).
Also, this provides a multi-threaded version of Cbc thanks to a last minute catch by @ianfiske