Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load an LP64 backend the new version of Clp_jll.jl #150

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

amontoison
Copy link
Contributor

No description provided.

@amontoison
Copy link
Contributor Author

@odow
Can you trigger this CI builds?

@odow
Copy link
Member

odow commented Jul 24, 2024

I guess this is needed, but it is unrelated to the aarch64-apple stuff.

@amontoison
Copy link
Contributor Author

I guess this is needed, but it is unrelated to the aarch64-apple stuff.

We should try to use a version of Clp compiled in debug mode but I highly suspect that the issue is upstream.

@odow
Copy link
Member

odow commented Jul 24, 2024

See #131 (comment)

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (01f0d01) to head (2be48d8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   82.01%   82.72%   +0.71%     
==========================================
  Files           3        3              
  Lines         378      382       +4     
==========================================
+ Hits          310      316       +6     
+ Misses         68       66       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit cde85a1 into jump-dev:master Jul 24, 2024
10 checks passed
@amontoison amontoison deleted the lbt-clp branch July 24, 2024 05:09
@amontoison
Copy link
Contributor Author

I guess this is needed, but it is unrelated to the aarch64-apple stuff.

I'm 99% sure that they never tested the compilation of Clp with Clang on Apple Silicon and always tested with gcc.
gcc was needed during a very long time because of incomplete support of OpenMP with the Clang compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants