Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

norm vs opnorm transition should be completed #382

Closed
ericphanson opened this issue Mar 21, 2020 · 3 comments · Fixed by #528
Closed

norm vs opnorm transition should be completed #382

ericphanson opened this issue Mar 21, 2020 · 3 comments · Fixed by #528
Labels
Milestone

Comments

@ericphanson
Copy link
Collaborator

Right now, if A is a matrix, then norm(A,p) emits a deprecation warning and calls opnorm(A,p), in line with Julia 0.7. In the next breaking release, we should make norm(A,p) call norm(vec(A), p) as the deprecation warning states, and remove the warning.

@ericphanson
Copy link
Collaborator Author

ericphanson commented Jan 17, 2021

Step 1: remove norm(A, p) for matrices at all, so it produces an error. This was done in v0.14.0 via #412.
Step 2: re-introduce norm(A, p) as norm(vec(A), p). This will be done in v0.15.0.

This way, hopefully users will not get incorrect answers if they haven't noticed the deprecation warnings (which are off by default on Julia 1.5+).

@ericphanson ericphanson added this to the v0.15.0 milestone Jan 17, 2021
@odow
Copy link
Member

odow commented Dec 30, 2023

@ericphanson what is the status of this?

@ericphanson
Copy link
Collaborator Author

I will put up a PR to finish it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants