Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing matrix norm and removing deprecation warning #400

Closed
raphaelchinchilla opened this issue Aug 28, 2020 · 2 comments
Closed

Fixing matrix norm and removing deprecation warning #400

raphaelchinchilla opened this issue Aug 28, 2020 · 2 comments

Comments

@raphaelchinchilla
Copy link

About 2 years ago, commit #242 aimed to fixed #231 by changing some behaviors and including a deprecation warning.

Until today, given a matrix M, norm(M) computes the operator norm instead of the frobenius norm. This behavior is not documented and is not consistent with Julia's.

I suggest finishing commit #242 and deprecate the old behavior. I would do a PR, but I am not familiar enough yet with Julia to feel confident about it
@ericphanson
Copy link
Collaborator

agreed! (see also #382)

@ericphanson ericphanson mentioned this issue Jan 17, 2021
Merged
@ericphanson
Copy link
Collaborator

I'll close this in favor of #382. Step 1 will be done in the imminent v0.14.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericphanson @raphaelchinchilla