Update IIS support to MOI 0.9.14. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
May 20, 2020
|
Based on jump-dev/MathOptInterface.jl#1091, I used Is it good enough to be merged? (Once MOI 0.9.14 is tagged.) |
blegat
reviewed
May 29, 2020
blegat
reviewed
May 29, 2020
|
With MOI 0.9.14 being tagged, maybe this could get merged? |
|
Oops. Sorry for dropping the ball on this. Feel free to ping earlier :) Can you post a screenshot with the tests passing? Looks good otherwise. |
|
Same as for CPLEX:
|
|
Can you rebase to solve the conflict |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jump-dev/MathOptInterface.jl#1056 is merged and will be included in the next MOI release.
Several return codes are not yet in MOI, though. Should they be included in MOI?