Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup log and logdet cones #756

Merged
merged 5 commits into from
Oct 6, 2021
Merged

cleanup log and logdet cones #756

merged 5 commits into from
Oct 6, 2021

Conversation

lkapelevich
Copy link
Collaborator

@lkapelevich lkapelevich commented Oct 3, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #756 (d871ba1) into master (b4c4c75) will increase coverage by 0.02%.
The diff coverage is 96.87%.

❗ Current head d871ba1 differs from pull request most recent head 5a9120b. Consider uploading reports for the commit 5a9120b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   91.88%   91.91%   +0.02%     
==========================================
  Files          53       53              
  Lines        7964     8018      +54     
==========================================
+ Hits         7318     7370      +52     
- Misses        646      648       +2     
Impacted Files Coverage Δ
src/Cones/generalizedpower.jl 98.13% <95.77%> (-1.17%) ⬇️
src/Cones/hypoperlog.jl 99.46% <100.00%> (-0.02%) ⬇️
src/Cones/hypoperlogdettri.jl 99.13% <100.00%> (-0.02%) ⬇️
src/Cones/epipersepspectral/vectorcsqr.jl 99.55% <0.00%> (-0.01%) ⬇️
src/Cones/hypogeomean.jl 99.35% <0.00%> (ø)
src/Cones/hyporootdettri.jl 100.00% <0.00%> (ø)
src/Cones/epipersepspectral/matrixcsqr.jl 100.00% <0.00%> (ø)
src/Cones/epirelentropy.jl 98.39% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e14878...5a9120b. Read the comment docs.

@chriscoey chriscoey changed the title WIP: simplify constants in log cone inv hess oracles cleanup log and logdet cones Oct 6, 2021
@chriscoey chriscoey merged commit adaf2fd into master Oct 6, 2021
@chriscoey chriscoey deleted the loginvhess branch October 6, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants