Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup rootdet/geomean #757

Merged
merged 3 commits into from
Oct 4, 2021
Merged

cleanup rootdet/geomean #757

merged 3 commits into from
Oct 4, 2021

Conversation

chriscoey
Copy link
Collaborator

@chriscoey chriscoey commented Oct 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #757 (e59c471) into master (c7b4420) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e59c471 differs from pull request most recent head adf14d2. Consider uploading reports for the commit adf14d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files          53       53              
  Lines        8027     8025       -2     
==========================================
- Hits         7379     7377       -2     
  Misses        648      648              
Impacted Files Coverage Δ
src/Cones/hypogeomean.jl 99.35% <100.00%> (ø)
src/Cones/hyporootdettri.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b4420...adf14d2. Read the comment docs.

@chriscoey chriscoey changed the title WIP: adjust constants for rootdet cleanup rootdet/geomean Oct 4, 2021
@chriscoey chriscoey merged commit 6da5ec0 into master Oct 4, 2021
@chriscoey chriscoey deleted the rtdetconsts branch October 4, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant