-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for MOI 0.9 #170
Updates for MOI 0.9 #170
Conversation
@@ -12,7 +12,7 @@ MathProgBase = "fdba3010-5040-5b88-9595-932c9decdf73" | |||
|
|||
[compat] | |||
BinaryProvider = "≥ 0.5.3" | |||
MathOptInterface = "~0.8.1" | |||
MathOptInterface = "0.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "~0.9"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both "0.9"
and "~0.9"
are equivalent, no ?: https://julialang.github.io/Pkg.jl/v1/compatibility/
For "0.9"
, it's ok if you don't change the left-most nonzero so the interval is [0.9, 0.10)
.
For "~0.9"~, it's ok if you only modify patch so the interval is
[0.9, 0.10)` as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caret specifiers are the default and hence 1.2.3 == ^1.2.3
PkgB = "^1.2" # [1.2.0, 2.0.0)
If I understand correctly, "0.9" would allow anything up to 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A caret specifier allows upgrade that would be compatible according to semver. An updated dependency is considered compatible if the new version does not modify the left-most non zero digit in the version specifier.
For "1.2.3", the left-most is "1" so "1.3" does not modify the left-most nonzero.
For "0.9", the left-most is "9" so "0.10" does modify the left-most nonzero.
According to jump-dev/MathOptInterface.jl#736 |
This was discussed on Gitter on June 03.
So we could implement it and call |
I don't expect to have time to tidy this up and merge before the weekend, so it's up for grabs until then. |
@mlubin Good to merge and release as Ipopt v0.6.1 ? |
.travis.yml
Outdated
@@ -11,6 +11,9 @@ sudo: false | |||
addons: | |||
apt_packages: | |||
- gfortran | |||
# TODO: Remove before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed
@@ -12,7 +12,7 @@ MathProgBase = "fdba3010-5040-5b88-9595-932c9decdf73" | |||
|
|||
[compat] | |||
BinaryProvider = "≥ 0.5.3" | |||
MathOptInterface = "~0.8.1" | |||
MathOptInterface = "0.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Thanks Miles!!! |
Do not merge until MOI 0.9 is tagged.