Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement algebra with UniformScaling #1993

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Implement algebra with UniformScaling #1993

merged 2 commits into from
Jun 28, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 20, 2019

Closes #1989
Also fixes JuliaLang/julia#32374 for JuMP variables

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #1993 into master will decrease coverage by 0.01%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   88.86%   88.84%   -0.02%     
==========================================
  Files          33       33              
  Lines        4282     4295      +13     
==========================================
+ Hits         3805     3816      +11     
- Misses        477      479       +2
Impacted Files Coverage Δ
src/parse_expr.jl 85.38% <78.57%> (ø) ⬆️
src/operators.jl 83.26% <90.62%> (-0.07%) ⬇️
src/macros.jl 91.39% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36dc086...9a2e00e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #1993 into master will decrease coverage by 0.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1993      +/-   ##
=========================================
- Coverage   89.11%   89.1%   -0.02%     
=========================================
  Files          33      33              
  Lines        4299    4312      +13     
=========================================
+ Hits         3831    3842      +11     
- Misses        468     470       +2
Impacted Files Coverage Δ
src/parse_expr.jl 85.38% <78.57%> (ø) ⬆️
src/operators.jl 86.24% <96.15%> (-0.12%) ⬇️
src/macros.jl 91.39% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fdad2b...425f007. Read the comment docs.

src/operators.jl Show resolved Hide resolved
src/operators.jl Show resolved Hide resolved
@blegat blegat force-pushed the bl/uniform_scaling branch from 6479f39 to 520fa2b Compare June 27, 2019 09:19
@blegat blegat merged commit 8e7b117 into master Jun 28, 2019
@odow odow deleted the bl/uniform_scaling branch June 29, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

eltype of -Symmetric(Q) Sum identity and matrix of variables
2 participants