Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add deprecation notes to the legacy nonlinear interface docstrings #3711

Merged
merged 8 commits into from
Mar 17, 2024

Conversation

odow
Copy link
Member

@odow odow commented Mar 13, 2024

I think this has been in enough use now that we can recommend it more strongly.

Preview: https://jump.dev/JuMP.jl/previews/PR3711/api/JuMP/#@NLconstraint

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (a16b383) to head (e436314).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3711   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          43       43           
  Lines        5736     5737    +1     
=======================================
+ Hits         5643     5644    +1     
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Mar 13, 2024

I wonder if we should also remove the warning:

image

We've had lots of people use this now, and I've only heard good things.

@odow odow merged commit 1aedb44 into master Mar 17, 2024
11 checks passed
@odow odow deleted the od/deprecate-nonlinear branch March 17, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants