Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing when show called on invalid variable or constraint #3763

Merged
merged 3 commits into from
May 31, 2024

Conversation

odow
Copy link
Member

@odow odow commented May 31, 2024

test/test_print.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (99ab0b2) to head (78018cc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3763   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          44       44           
  Lines        5873     5879    +6     
=======================================
+ Hits         5778     5784    +6     
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can ignore PolyJuMP and SumOfSquares failing, I'm doing a big refactoring

@odow
Copy link
Member Author

odow commented May 31, 2024

So you're okay with just printing "InvalidXXX"?

@blegat
Copy link
Member

blegat commented May 31, 2024

Yes, the variable is invalid so using it in a model should throw but we could allow printing it and InvalidXXX seems reasonable.

@odow odow merged commit 56b186f into master May 31, 2024
11 checks passed
@odow odow deleted the od/show-invalid branch May 31, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Deleting part of containerized constraints makes whole constraint unprintable
2 participants