Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change show(::IO, ::GenericModel) to a more informative tree structure #3803

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

odow
Copy link
Member

@odow odow commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (23ccb2c) to head (f7dce00).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3803      +/-   ##
==========================================
- Coverage   98.40%   97.90%   -0.51%     
==========================================
  Files          44       44              
  Lines        5968     6010      +42     
==========================================
+ Hits         5873     5884      +11     
- Misses         95      126      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, I like it

@odow
Copy link
Member Author

odow commented Aug 9, 2024

@pulsipher this breaks a printing test in InfiniteOpt. Thoughts?

@pulsipher
Copy link
Contributor

@pulsipher this breaks a printing test in InfiniteOpt. Thoughts?

This is not unexpected and I think this is a good PR. I can update InfiniteOpt once this PR is merged and make that particular test more robust printing changes in JuMP when I am at it.

@odow odow merged commit 52bb94f into master Aug 10, 2024
10 of 11 checks passed
@odow odow deleted the od/show-model branch August 10, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Model's print summary should include value type
3 participants