Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for shapes and dual shapes #3816

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Add more tests for shapes and dual shapes #3816

merged 3 commits into from
Sep 2, 2024

Conversation

odow
Copy link
Member

@odow odow commented Sep 2, 2024

Closes #3808

@blegat: thoughts?

test/test_constraint.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (4783914) to head (14755ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3816   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          44       44           
  Lines        6022     6022           
=======================================
  Hits         5896     5896           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat
Copy link
Member

blegat commented Sep 2, 2024

This is nice, if we had a checklist for adding shapes, we could add it to the checklist

@odow
Copy link
Member Author

odow commented Sep 2, 2024

Okay, I'll add a checklist.

@odow odow merged commit 526a013 into master Sep 2, 2024
11 checks passed
@odow odow deleted the od/test-shape branch September 2, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add better tests for shapes
2 participants