Skip to content

Conversation

odow
Copy link
Member

@odow odow commented Sep 10, 2024

Take II of #3441
x-ref #3438

TODOs

  • Add documentation to extension
  • Rework existing tutorials to leverage new syntax

See https://jump.dev/JuMP.jl/previews/PR3821/extensions/DataFrames/

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (9fb707c) to head (890ede8).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3821      +/-   ##
==========================================
+ Coverage   97.90%   97.92%   +0.01%     
==========================================
  Files          44       46       +2     
  Lines        6022     6077      +55     
==========================================
+ Hits         5896     5951      +55     
  Misses        126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Sep 10, 2024

@odow odow added the Status: Needs developer call This should be discussed on a monthly developer call label Sep 11, 2024
@blegat
Copy link
Member

blegat commented Oct 4, 2024

We could also have an array with the same syntax as SparseAxisArray and a DataFrame instead of a Dict as a backend.
I guess we could also have both the container of your PR and the one I just suggested.

Comment on lines +138 to +141
julia> DataFrames.combine(
DataFrames.groupby(x, :j),
:value => df_constraint => :value,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call the in-place operations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the question. It's not in-place. It creates a new DataFrame

@odow odow closed this Oct 31, 2024
@odow odow deleted the od/db branch October 31, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Needs developer call This should be discussed on a monthly developer call

Development

Successfully merging this pull request may close these issues.

3 participants