Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AffExpr() with zero(AffExpr) #466

Merged
merged 1 commit into from
Jun 17, 2015
Merged

Replace AffExpr() with zero(AffExpr) #466

merged 1 commit into from
Jun 17, 2015

Conversation

joehuchette
Copy link
Contributor

This started bugging me.

@IainNZ
Copy link
Collaborator

IainNZ commented Jun 14, 2015

Hmmmmmm

@mlubin
Copy link
Member

mlubin commented Jun 15, 2015

Hmmmmm. I see the stylistic motivation for preferring zero(AffExpr), but I don't see a need to deprecate the constructors. Seems like unnecessary churn in user code.

@joehuchette
Copy link
Contributor Author

I'll merge this w/o the deprecations then.

joehuchette added a commit that referenced this pull request Jun 17, 2015
@joehuchette
Merge pull request #466 from JuliaOpt/pedantic
0d385f3 
Replace AffExpr() with zero(AffExpr)
@joehuchette joehuchette merged commit 0d385f3 into master Jun 17, 2015
@joehuchette joehuchette deleted the pedantic branch June 17, 2015 00:57
@YDHsieh YDHsieh mentioned this pull request Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joehuchette @IainNZ @mlubin