add parens around tests for in
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precedence of `in` vs `=>` changed in JuliaLang/julia#12285 parens in test/model.jl and sdp I should be running this locally but I'm not, can squash when done missed a comparison in sdp
|
Now scs isn't downloading, guess we need to tag that too. Sourceforge seems pretty useless these days |
|
Yeah, very much so. I haven't been very good about tagging but tried to at least fix master for the majority of the packages that I've regrettably inflicted sourceforge on. |
|
I think we're back to just the normal issues with Ipopt broken on OS X and SCS giving the wrong answers... |
mlubin
added a commit
that referenced
this pull request
Jul 25, 2015
add parens around tests for `in`
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precedence of
=>changed in JuliaLang/julia#12285