Do zero checking to avoid unnecessary work in addToExpression #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Just needs 0.3 |
|
@IainNZ is this the same (terrifying) Travis error you were seeing? |
|
Sure is |
|
I kinda love that AppVeyor is finally the one passing and the others are failing |
| @@ -39,15 +41,19 @@ function addToExpression(aff::GenericAffExpr,c::Number,x::Number) | |||
| end | |||
|
|
|||
| function addToExpression{C,V}(aff::GenericAffExpr{C,V}, c::Number, x::V) | |||
There was a problem hiding this comment.
Is it me or is this method identical to the one above on line 31?
There was a problem hiding this comment.
No, they're the same
joehuchette
added a commit
that referenced
this pull request
Aug 15, 2015
Do zero checking to avoid unnecessary work in addToExpression
|
The Travis failure looks like a recompilation issue with DataStructures; I can reproduce locally. |
|
Actually I think DataStructures was just in a broken state, I officially have no idea what's going on now. |
|
Report upstream? I can reproduce with |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #535