Remove special-cased matmul in addToExpression... #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -501,13 +501,45 @@ for op in [:+, :-, :*, :/]; @eval begin | |||
| end | |||
| end; end | |||
|
|
|||
| # Special-case sparse matrix scalar multiplicaiton | |||
| for op in [:*, :/]; @eval begin | |||
| function $op{T<:JuMPTypes}(lhs::Number,rhs::Array{T}) | |||
There was a problem hiding this comment.
Whats the intuition for these things not working for SparseMatrices?
There was a problem hiding this comment.
m = Model()
@defVar(m, x)
A = SparseMatrixCSC(3, 3, [1:4;], [1:3;], [x,x,x])
B = 3AYou want B to be sparse as well, which similar gives you, but then eachindex does iteration over all elements, not just nonzeros.
joehuchette
added a commit
that referenced
this pull request
Sep 5, 2015
Remove special-cased matmul in addToExpression...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and fix some bugs it revealed.