Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #346, this adds a runtime version of our
@gendict
macro so thatand
produce the same object (that is,
x::Vector{Variable}
). This implementation is type unstable, which I think is inevitable, given that we produce different types forT=1:3
andT=2:3
. In the benchmarks updates I pushed, this lead to about a 4x performance hit in the worst-case, though there may be more serious performance hits in other settings.This PR takes the current behavior, which has opaque difference in semantics, with something that has the same behavior, but opaque differences in performance. If the performance hit is just 4x, I think this may be a reasonable change (and could get better without all the evaling once we switch to proper
JuMPArray
s), but I'm not certain.