deprecation fixes for julia 0.5 #810
Conversation
Current coverage is 84.71% (diff: 100%)@@ master #810 diff @@
==========================================
Files 18 18
Lines 4221 4221
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 3576 3576
Misses 645 645
Partials 0 0
|
| @@ -23,8 +23,6 @@ using Compat | |||
|
|
|||
| import Compat: UTF8String, view | |||
|
|
|||
| @compat import Base.show | |||
|
|
|||
There was a problem hiding this comment.
I thought this was still needed for the writemime patch? See here.
There was a problem hiding this comment.
Probably. I broke 0.4 with this, need to fix up.
On Jul 29, 2016 09:04, "Jarrett Revels" notifications@github.com wrote:
In src/JuMP.jl
#810 (comment):@@ -23,8 +23,6 @@ using Compat
import Compat: UTF8String, view
-@compat import Base.show
I thought this was still needed for the writemime patch? See here
JuliaLang/Compat.jl#219.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JuliaOpt/JuMP.jl/pull/810/files/7e57d0c55f6b5089a3d70c6728258c9f90b32f18#r72806821,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABp0M4PaN-YYXClTQT0pYUVdDrYloohKks5qahZmgaJpZM4JYOi6
.
|
JuMP will be deprecation-free after this, I think. Solver wrappers need work though. |
Thanks @jrevels