Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bridges] fix bug in HermitianToSymmetricPSDBridge #2171

Merged
merged 3 commits into from
May 14, 2023

Conversation

odow
Copy link
Member

@odow odow commented May 13, 2023

Closes #2170

@odow odow requested a review from blegat May 13, 2023 04:11
@odow
Copy link
Member Author

odow commented May 13, 2023

@blegat, I didn't really understand your indexing logic, so I just started from scratch, working my way through the result vector in a single pass.

inverse_map_function is correct, but you should take a look at adjoint_map_function. I don't really understand what it's doing or if it's correct.

@odow
Copy link
Member Author

odow commented May 13, 2023

cc @araujoms

You can try this branch with:

] add MathOptInterface#od/fix-hermitian-bridge

@araujoms
Copy link

Just tested it, works like a charm.

@blegat
Copy link
Member

blegat commented May 14, 2023

Arf, I messed up the adjoint of the imaginary part, that's the issue when coding without a pen and paper. It would be quite unreadable to maintain the index as it is moving horizontally and not vertically (because of the transpose) so I switched to using trimap

@odow odow merged commit 393825a into master May 14, 2023
@odow odow deleted the od/fix-hermitian-bridge branch May 14, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug in HermitianToSymmetricPSDBridge
3 participants