Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] rename Test module to avoid conflict with Base.Test #2267

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Sep 18, 2023

JET is getting to the point where it can analyze MathOptInterface. (Previously blocked by aviatesk/JET.jl#289 and aviatesk/JET.jl#521.)

Now it's blocked by the fact that MOI.Test.Test is not MOI.Test. It seems like this could be problematic in general, and it'd be nice to start looking at the warnings given by JET. It seems like static analysis is only going to increase in popularity in Julia.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround

@odow odow merged commit dc166f6 into master Sep 18, 2023
16 checks passed
@odow odow deleted the od/Test branch September 18, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants