Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for v1.20.1 #2288

Merged
merged 6 commits into from
Sep 24, 2023
Merged

Prep for v1.20.1 #2288

merged 6 commits into from
Sep 24, 2023

Conversation

odow
Copy link
Member

@odow odow commented Sep 21, 2023

TODO

Basic

  • version field of Project.toml has been updated
    - If a breaking change, increment the MAJOR field and reset others to 0
    - If adding new features, increment the MINOR field and reset PATCH to 0
    - If adding bug fixes or documentation changes, increment the PATCH field

Documentation

  • Add a new entry to docs/src/changelog.md, following existing style

Tests

docs/src/changelog.md Outdated Show resolved Hide resolved
docs/src/changelog.md Outdated Show resolved Hide resolved
@odow odow closed this Sep 22, 2023
@odow odow reopened this Sep 22, 2023
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off until my concern in #2284 is addressed, I think we should revert #2285 as it might cause more issues by fixing an invalid use case

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can release, the benchmark of #2284 (comment) shows there is no regression

docs/src/changelog.md Outdated Show resolved Hide resolved
docs/src/changelog.md Outdated Show resolved Hide resolved
@odow odow merged commit 5c9db2e into master Sep 24, 2023
16 checks passed
@odow odow deleted the od/v1.20.1 branch September 24, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants