[Utilities] add more distance_to_set implementations #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't added the matrix cones (or the constraint programming ones, or things like indicator and complementarity), but this is a reasonably complete list for 95% of the use-cases. |
odow
commented
Oct 23, 2023
|
Thoughts @matbesancon? |
I don't think we should require having an implementation for any set or should aim as covering "most" use case. It's more like, if someone has an short and simple distance computation without any dependency and makes a PR that is well tested then we'll accept it in MOI and it does not have to be in MOSD. |
blegat
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2033
These are really painful to test and check that they are correct. It's easy to make a mistake.